Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): Add settings.jsdoc #2706

Merged
merged 4 commits into from
Mar 14, 2024
Merged

feat(linter): Add settings.jsdoc #2706

merged 4 commits into from
Mar 14, 2024

Conversation

leaysgur
Copy link
Contributor

@leaysgur leaysgur commented Mar 13, 2024

Base work for #2642 🏃🏻

  • struct
  • bool flags
  • tagNamePreferences

@github-actions github-actions bot added the A-linter Area - Linter label Mar 13, 2024
Copy link

codspeed-hq bot commented Mar 13, 2024

CodSpeed Performance Report

Merging #2706 will not alter performance

Comparing plugin-jsdoc-settings (4267517) with main (f8fe3af)

Summary

✅ 29 untouched benchmarks

@leaysgur leaysgur marked this pull request as ready for review March 14, 2024 07:29
@leaysgur leaysgur requested a review from Boshen March 14, 2024 12:36
@Boshen Boshen merged commit 53a8e7f into main Mar 14, 2024
22 checks passed
@Boshen Boshen deleted the plugin-jsdoc-settings branch March 14, 2024 14:34
@Boshen
Copy link
Member

Boshen commented Mar 14, 2024

Thank you for working on this!

Boshen pushed a commit that referenced this pull request Apr 4, 2024
Part of #1170, Finally... 🗻 

Some preparation PRs may be needed in advance.

- [x] settings.jsdoc #2706 
- [x] new struct design #2765
- [x] handle `Span` for diagnostics #2815

Implement plugin itself.

-
https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/rules/check-access.md
-
https://github.com/gajus/eslint-plugin-jsdoc/blob/main/src/rules/checkAccess.js

I'll send a PR to make this plugin public after confirming that a few
more rules can be implemented without any problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants