Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): remove unnecessary check in eslint/no-global-assign #3391

Conversation

mysteryven
Copy link
Contributor

Looks like we don't need check this, as unresolved references don't have symbolId:

let reference_name = reference.name().clone();
let reference_id = self.symbols.create_reference(reference);
if add_unresolved_reference {
self.scope.add_unresolved_reference(
self.current_scope_id,
reference_name,
reference_id,
);
} else {
self.resolve_reference_ids(reference_name.clone(), vec![reference_id]);
}
reference_id

Copy link

graphite-app bot commented May 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

mysteryven commented May 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on Graphite Graphite

@Boshen Boshen changed the title chore(linter): remove unnessnary check in eslint/no-global-assign refactor(linter): remove unnecessary check in eslint/no-global-assign May 23, 2024
@mysteryven mysteryven force-pushed the 05-23-feat_linter_eslint/no-restricted-globals branch from 085d786 to 27a18dc Compare May 24, 2024 00:14
@mysteryven mysteryven force-pushed the 05-23-chore_linter_remove_unnessnary_check_in_eslint/no-global-assign_ branch from 9682f94 to fba569e Compare May 24, 2024 00:14
Copy link

codspeed-hq bot commented May 24, 2024

CodSpeed Performance Report

Merging #3391 will improve performances by 3.41%

Comparing 05-23-chore_linter_remove_unnessnary_check_in_eslint/no-global-assign_ (d8c3187) with main (b8997f5)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main 05-23-chore_linter_remove_unnessnary_check_in_eslint/no-global-assign_ Change
semantic[antd.js] 216.6 ms 209.5 ms +3.41%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 24, 2024
Copy link

graphite-app bot commented May 24, 2024

Merge activity

  • May 23, 10:30 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 23, 10:30 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • May 23, 10:38 PM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 05-23-feat_linter_eslint/no-restricted-globals branch from 27a18dc to b8997f5 Compare May 24, 2024 02:30
@Boshen Boshen changed the base branch from 05-23-feat_linter_eslint/no-restricted-globals to main May 24, 2024 02:33
@Boshen Boshen force-pushed the 05-23-chore_linter_remove_unnessnary_check_in_eslint/no-global-assign_ branch from fba569e to d8c3187 Compare May 24, 2024 02:34
@graphite-app graphite-app bot merged commit d8c3187 into main May 24, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 05-23-chore_linter_remove_unnessnary_check_in_eslint/no-global-assign_ branch May 24, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants