-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): remove unnecessary check in eslint/no-global-assign
#3391
refactor(linter): remove unnecessary check in eslint/no-global-assign
#3391
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mysteryven and the rest of your teammates on |
eslint/no-global-assign
eslint/no-global-assign
085d786
to
27a18dc
Compare
9682f94
to
fba569e
Compare
CodSpeed Performance ReportMerging #3391 will improve performances by 3.41%Comparing Summary
Benchmarks breakdown
|
Merge activity
|
27a18dc
to
b8997f5
Compare
…n` (#3391) Looks like we don't need check this, as unresolved references don't have `symbolId`: https://github.com/oxc-project/oxc/blob/bb25c54b94ff778e3598bb0f528d43a0c78333a0/crates/oxc_semantic/src/builder.rs#L292-L303
fba569e
to
d8c3187
Compare
Looks like we don't need check this, as unresolved references don't have
symbolId
:oxc/crates/oxc_semantic/src/builder.rs
Lines 292 to 303 in bb25c54