-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add jest test file to benchmarks #4792
Conversation
This will help bench Jest linter rules. See conversation in #4787 for details.
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4792 will not alter performanceComparing Summary
Benchmarks breakdown
|
oxc/tasks/benchmark/benches/linter.rs Lines 18 to 24 in d191823
And adding more test files will hurt CI time 😢 oxc/.github/workflows/benchmark.yml Lines 162 to 164 in d191823
|
This isn't directly related to this PR but I just want to express something on my mind. I believe we can use an on-demand CI pass for heavy stuff. Instead of running some of the CI tasks on push we can use the action button or provide a command through @oxc-bot. We can benchmark general stuff like before(on push) but provide a command for maintainers and the PR's author to run e2e benchmarks, oxlint-ecosystem, monitor-oxc, or other complicated tasks. We usually only need to run these once per review, Sometime we wouldn't even need to run these on trivial changes which saves a lot of trees(as suggested by @overlookmotel). I've mentioned it here before oxc-project/backlog#86 I also noticed @overlookmotel is working toward filtering CI tasks so they only run on appropriate changes. That can help as well. I wish Graphite's CI optimization had a better way to strategize tasks and where they should run. |
Closing in favor of selective benchmark setup. |
This will help bench Jest linter rules. See conversation in #4787 for details.