Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic): clean up transform checker #5094

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 22, 2024

Remove some defunct code and clean up a few bits in transform checker.

Copy link

codspeed-hq bot commented Aug 22, 2024

CodSpeed Performance Report

Merging #5094 will not alter performance

Comparing 08-22-refactor_semantic_clean_up_transform_checker (13c961c) with main (0b90011)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-22-refactor_semantic_clean_up_transform_checker branch from 7f9bea9 to 37d8972 Compare August 22, 2024 19:47
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 22, 2024 — with Graphite App
Copy link

graphite-app bot commented Aug 22, 2024

Merge activity

@Boshen Boshen force-pushed the 08-22-fix_semantic_transform_checker_check_unbound_references branch from 0d8eff5 to ce67a76 Compare August 22, 2024 23:43
Boshen pushed a commit that referenced this pull request Aug 22, 2024
Remove some defunct code and clean up a few bits in transform checker.
@Boshen Boshen force-pushed the 08-22-refactor_semantic_clean_up_transform_checker branch from 37d8972 to c58f88a Compare August 22, 2024 23:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 22, 2024
@overlookmotel overlookmotel force-pushed the 08-22-fix_semantic_transform_checker_check_unbound_references branch from ce67a76 to 0dd513a Compare August 23, 2024 00:14
overlookmotel added a commit that referenced this pull request Aug 23, 2024
Remove some defunct code and clean up a few bits in transform checker.
@overlookmotel overlookmotel force-pushed the 08-22-refactor_semantic_clean_up_transform_checker branch from c58f88a to e018069 Compare August 23, 2024 00:16
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
Remove some defunct code and clean up a few bits in transform checker.
@overlookmotel overlookmotel force-pushed the 08-22-fix_semantic_transform_checker_check_unbound_references branch from 0dd513a to c57e078 Compare August 23, 2024 07:39
@overlookmotel overlookmotel force-pushed the 08-22-refactor_semantic_clean_up_transform_checker branch from e018069 to 13c961c Compare August 23, 2024 07:42
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
Base automatically changed from 08-22-fix_semantic_transform_checker_check_unbound_references to main August 23, 2024 07:46
@graphite-app graphite-app bot merged commit 13c961c into main Aug 23, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 08-22-refactor_semantic_clean_up_transform_checker branch August 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants