Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter) false positive in jest/no-untyped-mock-factory #5123

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Aug 23, 2024

part of #5103

Copy link

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review August 23, 2024 12:04
Copy link
Contributor Author

camc314 commented Aug 23, 2024

Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #5123 will not alter performance

Comparing c/08-23-fix_linter_false_positive_in_jest_no-untyped-mock-factory (525d664) with main (f7958c4)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 23, 2024
Copy link

graphite-app bot commented Aug 23, 2024

Merge activity

  • Aug 23, 8:45 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 23, 8:45 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 23, 8:48 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/08-23-fix_linter_fix_bug_in_fixer_for_prefer-function-type_when_interface_is_exported branch from 9068834 to b7ba9c0 Compare August 23, 2024 12:45
@Boshen Boshen force-pushed the c/08-23-fix_linter_false_positive_in_jest_no-untyped-mock-factory branch from 9f4a243 to 525d664 Compare August 23, 2024 12:46
Base automatically changed from c/08-23-fix_linter_fix_bug_in_fixer_for_prefer-function-type_when_interface_is_exported to main August 23, 2024 12:48
@graphite-app graphite-app bot merged commit 525d664 into main Aug 23, 2024
24 checks passed
@graphite-app graphite-app bot deleted the c/08-23-fix_linter_false_positive_in_jest_no-untyped-mock-factory branch August 23, 2024 12:48
@camc314 camc314 mentioned this pull request Aug 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants