Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-jsx-a11y(anchor-is-valid)): make the rule work correctly and improve error grammar #5781

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

Arian94
Copy link
Contributor

@Arian94 Arian94 commented Sep 15, 2024

fixes #5746.

Copy link

graphite-app bot commented Sep 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 15, 2024
Copy link

codspeed-hq bot commented Sep 15, 2024

CodSpeed Performance Report

Merging #5781 will not alter performance

Comparing Arian94:fix/5746 (e31aa57) with main (148c7a8)

Summary

✅ 29 untouched benchmarks

@Arian94 Arian94 changed the title Fix(eslint-plugin-jsx-a11y(anchor-is-valid)): make the rule work correctly and improve error grammar fix(eslint-plugin-jsx-a11y(anchor-is-valid)): make the rule work correctly and improve error grammar Sep 15, 2024
Copy link
Contributor

@DonIsaac DonIsaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM!

@DonIsaac DonIsaac merged commit d1d54a6 into oxc-project:main Sep 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-jsx-a11y(anchor-is-valid): working incorrectly
2 participants