Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): shorten code #5915

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Sep 20, 2024

#5904 reduced the generated code for Visit trait. Shorten the codegen a little after that change.

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Sep 20, 2024
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #5915 will not alter performance

Comparing 09-20-refactor_ast_tools_shorten_code (b80a9ee) with main (eadffb9)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review September 20, 2024 09:35
@overlookmotel overlookmotel requested a review from rzvxa September 20, 2024 09:44
Copy link
Contributor

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this seems like a good follow up to me

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2024
@overlookmotel
Copy link
Contributor Author

Thanks for reviewing @camchenry!

Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

  • Sep 20, 10:11 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 20, 10:12 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 20, 10:18 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

#5904 reduced the generated code for `Visit` trait. Shorten the codegen a little after that change.
@overlookmotel overlookmotel force-pushed the 09-20-refactor_ast_tools_shorten_code branch from f3b85dd to b80a9ee Compare September 20, 2024 14:15
@graphite-app graphite-app bot merged commit b80a9ee into main Sep 20, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 09-20-refactor_ast_tools_shorten_code branch September 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants