Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linter): import test cases for no-empty-character-class #5981

Conversation

camchenry
Copy link
Contributor

@camchenry camchenry commented Sep 22, 2024

Copy link

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

camchenry commented Sep 22, 2024

@github-actions github-actions bot added the A-linter Area - Linter label Sep 22, 2024
@camchenry camchenry force-pushed the 09-22-refactor_linter_use_parsed_patterns_in_no-empty-character-class_rule branch from 324cb84 to d75ddbd Compare September 22, 2024 23:53
@camchenry camchenry force-pushed the 09-22-test_linter_import_test_cases_for_no-empty-character-class_ branch from b021e30 to 8789eb1 Compare September 22, 2024 23:54
@camchenry camchenry marked this pull request as ready for review September 22, 2024 23:55
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #5981 will not alter performance

Comparing 09-22-test_linter_import_test_cases_for_no-empty-character-class_ (b681c9a) with main (d24985e)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2024
Copy link

graphite-app bot commented Sep 23, 2024

Merge activity

  • Sep 22, 8:32 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 22, 8:32 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 22, 8:39 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the 09-22-refactor_linter_use_parsed_patterns_in_no-empty-character-class_rule branch from d75ddbd to 2cf2edd Compare September 23, 2024 00:33
@DonIsaac DonIsaac force-pushed the 09-22-test_linter_import_test_cases_for_no-empty-character-class_ branch from 8789eb1 to b681c9a Compare September 23, 2024 00:34
Base automatically changed from 09-22-refactor_linter_use_parsed_patterns_in_no-empty-character-class_rule to main September 23, 2024 00:37
@graphite-app graphite-app bot merged commit b681c9a into main Sep 23, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 09-22-test_linter_import_test_cases_for_no-empty-character-class_ branch September 23, 2024 00:39
@oxc-bot oxc-bot mentioned this pull request Sep 23, 2024
Boshen added a commit that referenced this pull request Sep 23, 2024
## [0.9.7] - 2024-09-23

### Features

- d24985e linter: Add `oxc-security/api-keys` (#5906) (DonIsaac)
- f9b44c5 linter: Add unicode sets support to `no-useless-escape` rule
(#5974) (camchenry)
- 0f19848 linter: Implement `no-unexpected-multiline` rule (#5911)
(camchenry)
- 16fe383 linter: Implement `no-extend-native` rule (#5867) (Cam
McHenry)

### Bug Fixes

- eed9ac7 linter: Include actual span size in `no-regex-spaces`
diagnostic (#5957) (camchenry)
- 40c89c2 linter: Move `promise/avoid-new` to style category (#5961)
(DonIsaac)

### Performance

- 608d637 linter: Use `aho-corasick` instead of `regex` for string
matching in `jsx-a11y/img-redundant-alt` (#5892) (camchenry)
- 3148d4b linter: Check file path after checking node kind for
`nextjs/no-head-element` (#5868) (Cam McHenry)

### Refactor

- 0a5a4a9 linter: Use parsed patterns for `unicorn/no-hex-escape`
(#5985) (camchenry)
- 2cf2edd linter: Use parsed patterns in `no-empty-character-class` rule
(#5980) (camchenry)
- a9a8e2a linter: Use regex parser in `eslint/no-regex-spaces` (#5952)
(camchenry)
- 05f592b linter: Use parsed patterns in
`unicorn/prefer-string-starts-ends-with` (#5949) (camchenry)
- 3273b64 linter: Use parsed patterns for
`unicorn/prefer-string-replace-all` rule (#5943) (camchenry)
- ba7b01f linter: Add `LinterBuilder` (#5714) (DonIsaac)
- db4f16a semantic: Call `with_trivias` before `build_with_jsdoc`
(#5875) (Boshen)
- 3d13c6d semantic: Impl `IntoIterator` for `&AstNodes` (#5873)
(DonIsaac)

### Testing

- b681c9a linter: Import test cases for `no-empty-character-class`
(#5981) (camchenry)
- 767602b linter: Add regression test for #5227 (#5975) (camchenry)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants