Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linter): add OxlintRules::override_rules tests #6081

Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Sep 26, 2024

wrote these while working on better understanding this method in prep for the LinterBuilder migration.

Copy link

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 26, 2024
@DonIsaac DonIsaac marked this pull request as ready for review September 26, 2024 16:27
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #6081 will not alter performance

Comparing don/09-26-test_linter_add_oxlintrules_override_rules_tests (55949eb) with main (1a6923a)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac changed the base branch from don/09-26-chore_linter_add_filter_parsing_test_cases to graphite-base/6081 September 26, 2024 17:15
@DonIsaac
Copy link
Contributor Author

CodSpeed Performance Report

Merging #6081 will degrade performances by 25.26%

Comparing don/09-26-test_linter_add_oxlintrules_override_rules_tests (448a000) with don/09-26-chore_linter_add_filter_parsing_test_cases (a23c9a4)

Summary

❌ 1 regressions ✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark don/09-26-chore_linter_add_filter_parsing_test_cases don/09-26-test_linter_add_oxlintrules_override_rules_tests Change
isolated-declarations[vue-id.ts] 396.8 ms 530.9 ms -25.26%

Most likely a fluke, since I didn't touch anything in ID. I'll re-run benchmarks.

@DonIsaac DonIsaac force-pushed the don/09-26-test_linter_add_oxlintrules_override_rules_tests branch from 448a000 to 8ffa654 Compare September 26, 2024 17:19
@camchenry
Copy link
Contributor

CodSpeed Performance Report

Merging #6081 will degrade performances by 25.26%

Comparing don/09-26-test_linter_add_oxlintrules_override_rules_tests (448a000) with don/09-26-chore_linter_add_filter_parsing_test_cases (a23c9a4)

Summary

❌ 1 regressions ✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark don/09-26-chore_linter_add_filter_parsing_test_cases don/09-26-test_linter_add_oxlintrules_override_rules_tests Change
isolated-declarations[vue-id.ts] 396.8 ms 530.9 ms -25.26%

Most likely a fluke, since I didn't touch anything in ID. I'll re-run benchmarks.

agreed, doesn't seem like this would impact perf at all.

@DonIsaac DonIsaac changed the base branch from graphite-base/6081 to main September 26, 2024 17:20
@DonIsaac DonIsaac force-pushed the don/09-26-test_linter_add_oxlintrules_override_rules_tests branch from 8ffa654 to 9d644ae Compare September 26, 2024 17:20
@DonIsaac DonIsaac force-pushed the don/09-26-test_linter_add_oxlintrules_override_rules_tests branch from 9d644ae to d6ba62a Compare September 26, 2024 18:59
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Sep 26, 2024
Copy link

graphite-app bot commented Sep 26, 2024

Merge activity

  • Sep 26, 3:39 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 3:39 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 26, 3:44 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

wrote these while working on better understanding this method in prep for the `LinterBuilder` migration.
@DonIsaac DonIsaac force-pushed the don/09-26-test_linter_add_oxlintrules_override_rules_tests branch from d6ba62a to 55949eb Compare September 26, 2024 19:40
@graphite-app graphite-app bot merged commit 55949eb into main Sep 26, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/09-26-test_linter_add_oxlintrules_override_rules_tests branch September 26, 2024 19:44
@oxc-bot oxc-bot mentioned this pull request Sep 27, 2024
Boshen added a commit that referenced this pull request Sep 27, 2024
## [0.9.9] - 2024-09-27

### Bug Fixes

- bd8f786 linter: Rule and generic filters do not re-configure existing
rules (#6087) (DonIsaac)
- c5cdb4c linter: Disable all rules in a plugin when that plugin gets
turned off (#6086) (DonIsaac)
- 6c855af linter: Only write fix results if source code has changed
(#6096) (DonIsaac)
- 8759528 linter: Category filters not re-configuring already-enabled
rules (#6085) (DonIsaac)
- c2616f7 linter: Fix panic in fixer for `oxc/only-used-in-recursion`
(#6070) (camc314)
- 3da3845 linter: Malformed snippets in `eslint/for-direction` docs
(#6060) (DonIsaac)
- c047d42 linter: `no-useless-escape`: do not crash on backslash
character (#6048) (camchenry)
- 6f76ebe linter: Ignore invalid or partial disable directives (#6045)
(camchenry)
- 09a24cd linter: Fix false positives for generics in
`no-unexpected-multiline` (#6039) (camchenry)
- d05fd20 linter: Newline in type parameters causing false positive in
`no-unexpected-multiline` (#6031) (DonIsaac)
- 01b9c4b npm/oxlint: Make bin/oxc_language_server an executable (#6066)
(Boshen)

### Performance

- f8464a3 linter: `no-magic-numbers` remove redudant checks in
`is_array_index` (#6033) (Alexander S.)
- c16ae60 linter: `jest/prefer-hooks-in-order`: rewrite rule to allocate
less and iterate fewer times (#6030) (camchenry)

### Documentation

- a4fdf1b linter: Improve docs for promise rules (#6051) (dalaoshu)
- 21cdb78 linter: Fix incorrect "bad" example in
`only-used-in-recursion` (#6029) (Boshen)

### Refactor

- 1f92d61 linter: `jest/prefer-hooks-in-order`: improve diagnostic
messages (#6036) (camchenry)

### Testing

- 55949eb linter: Add `OxlintRules::override_rules` tests (#6081)
(DonIsaac)
- 1a6923a linter: Add filter parsing test cases (#6080) (DonIsaac)
- 58d333a linter: Add more test cases for disable directives (#6047)
(camchenry)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants