-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): eslint/no-fallthrough [BLOCKED] #633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc997d1
to
1e1876e
Compare
Blocked by needing the fallthrough cases computed from the semantic pass. |
CFG will unlikely happen in a short period of time so I'll close this for now to happen the PR list clean, I'll reopen this PR when CFG is ready. |
Instead of closing, I should merge some of this. |
649f731
to
37a983c
Compare
CodSpeed Performance ReportMerging #633 will not alter performanceComparing Summary
|
Boshen
pushed a commit
that referenced
this pull request
Jun 17, 2024
[no-fallthrough](https://eslint.org/docs/latest/rules/no-fallthrough) [oxlint-ecosystem-ci](https://github.com/rzvxa/oxlint-ecosystem-ci/actions/runs/9546510803) related to #633 and closes #597 also related to #3662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by control flow analysis
For #597
Summary
In eslint: https://eslint.org/docs/latest/rules/no-fallthrough
TODOs:
commentPattern
option. Ref: