fix(linter): friendly diagnostic messages for no-else-return

[DonIsaac]

Before

  ⚠ eslint(no-else-return): Unnecessary 'else' after 'return'.
   ╭─[no_else_return.tsx:1:48]
 1 │ function foo1() { if (true) { return x; } else { return y; } }
   ·                                                ─────────────
   ╰────
  help: Replace ` else { return y; }` with `  return y; `.

After

  ⚠ eslint(no-else-return): Unnecessary 'else' after 'return'.
   ╭─[no_else_return.tsx:1:31]
 1 │ function foo1() { if (true) { return x; } else { return y; } }
   ·                               ────┬────  ───┬──
   ·                                   │         ╰── Making this `else` block unnecessary.
   ·                                   ╰── This consequent block always returns,
   ╰────
  help: Remove the `else` block, moving its contents outside of the `if` statement.

[DonIsaac]

• fix(linter): friendly diagnostic messages for no-else-return #6349 👈
• fix(linter): no-else-return fixer fails when else has no trailing whitespace #6348
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6349 will not alter performance

_{Comparing don/10-07-fix_linter_friendly_diagnostic_messages_for_no-else-return_ (63f1622) with main (71ad5d3)}

Summary

✅ 29 untouched benchmarks

[graphite-app]

Merge activity

• Oct 7, 9:26 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 7, 9:26 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Oct 7, 9:31 PM EDT: Boshen merged this pull request with the Graphite merge queue.