Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): add more tests for comments from esbuild #6357

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Copy link

graphite-app bot commented Oct 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 8, 2024

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #6357 will not alter performance

Comparing 10-08-chore_codegen_add_a_more_useful_test (585cdd5) with main (62d45bf)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen changed the title chore(codegen): add a more useful test chore(codegen): add more tests for comments from esbuild Oct 8, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 8, 2024
Copy link

graphite-app bot commented Oct 8, 2024

Merge activity

  • Oct 8, 1:42 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 8, 1:42 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Oct 8, 1:49 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 10-08-fix_codegen_converts_line_comment_to_block_comment_if_it_is_a_pure_comment branch from 3c5c6b6 to 84b2d07 Compare October 8, 2024 05:43
@Boshen Boshen force-pushed the 10-08-chore_codegen_add_a_more_useful_test branch from ef9821e to 585cdd5 Compare October 8, 2024 05:43
Base automatically changed from 10-08-fix_codegen_converts_line_comment_to_block_comment_if_it_is_a_pure_comment to main October 8, 2024 05:48
@graphite-app graphite-app bot merged commit 585cdd5 into main Oct 8, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-08-chore_codegen_add_a_more_useful_test branch October 8, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants