Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(span): enable lint warnings on missing docs #6610

Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 15, 2024

Copy link

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 15, 2024
Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #6610 will not alter performance

Comparing don/10-15-chore_span_enable_lint_warnings_on_missing_docs (28b1b4e) with main (03427af)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac marked this pull request as ready for review October 15, 2024 20:32
@DonIsaac DonIsaac force-pushed the don/10-15-refactor_span_remove_unused_contenthash_content_hash_slice_ branch from 97f7431 to e756491 Compare October 15, 2024 21:55
@DonIsaac DonIsaac force-pushed the don/10-15-chore_span_enable_lint_warnings_on_missing_docs branch from 840feba to aac1527 Compare October 15, 2024 21:56
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 15, 2024 — with Graphite App
Copy link

graphite-app bot commented Oct 15, 2024

Merge activity

@Boshen Boshen force-pushed the don/10-15-refactor_span_remove_unused_contenthash_content_hash_slice_ branch from e756491 to 3faee66 Compare October 15, 2024 22:51
@Boshen Boshen force-pushed the don/10-15-chore_span_enable_lint_warnings_on_missing_docs branch from aac1527 to 28b1b4e Compare October 15, 2024 22:51
Base automatically changed from don/10-15-refactor_span_remove_unused_contenthash_content_hash_slice_ to main October 15, 2024 22:55
@graphite-app graphite-app bot merged commit 28b1b4e into main Oct 15, 2024
28 checks passed
@graphite-app graphite-app bot deleted the don/10-15-chore_span_enable_lint_warnings_on_missing_docs branch October 15, 2024 23:02
DonIsaac pushed a commit that referenced this pull request Oct 15, 2024
This attribute was added in #6610, but then removed again in #6612. I assume removing it was an accident.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants