feat(linter)!: report unmatched rules with error exit code #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @camchenry and the rest of your teammates on |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7027 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
10-30-feat_linter_report_unmatched_rules_with_error_exit_code
branch
from
a2d1e2a to
5078f69
Compare
camchenry
force-pushed
the
10-30-feat_linter_report_unmatched_rules_with_error_exit_code
branch
2 times, most recently
from
30660e0 to
f7134d9
Compare
Boshen
changed the title
DonIsaac
reviewed
Oct 30, 2024
camchenry
force-pushed
the
10-30-feat_linter_report_unmatched_rules_with_error_exit_code
branch
from
f7134d9 to
4dfd1e9
Compare
Boshen
reviewed
Oct 31, 2024
Boshen
reviewed
Oct 31, 2024
Boshen
reviewed
Oct 31, 2024
Merge activity
|
- closes #6988 we now return an error exit code when there are unmatched rules. previously, we would print an error to stderr and continue running. however, this masked errors in some tests that actually had unmatched rules in them. these test cases now trigger a panic (in tests only, not at runtime), and help ensure that we are reporting an error message to the user for unknown rules, which we did not have any tests cases for before. - fixes #7025 this also fixes #7025, where we were reporting rules as unmatched simply because they had been disabled prior to being configured. similar to #7009.
Boshen
force-pushed
the
10-30-feat_linter_report_unmatched_rules_with_error_exit_code
branch
from
4dfd1e9 to
1f2a6c6
Compare
graphite-app
bot
deleted the
10-30-feat_linter_report_unmatched_rules_with_error_exit_code
branch
|
https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/11623823150/job/32371532541 We need to fix preact with this change 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we now return an error exit code when there are unmatched rules. previously, we would print an error to stderr and continue running. however, this masked errors in some tests that actually had unmatched rules in them. these test cases now trigger a panic (in tests only, not at runtime), and help ensure that we are reporting an error message to the user for unknown rules, which we did not have any tests cases for before.
this also fixes #7025, where we were reporting rules as unmatched simply because they had been disabled prior to being configured. similar to #7009.