fix(eslint/no_undef): typescript utility types were detected as undefined variables

[Spoutnik97]

First contribution to this repo, and first contribution in Rust ! So, please, help me to improve my skills ;) $

fix #7007, fix #7008

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[nrayburn-tech]

While I don't actually know how to implement it, @Boshen mentioned checking for symbol flags in the issue. I assume that would mean not using a hard coded list like this.

[camc314]

hmm yeah this is rough, we would have to keep this list exactly up to date with the globals TS requires.

also, if a user was using a package that declares a global (type or var) this would break

[Spoutnik97]

I didn't found the ts types list in the repo. So this a first proposal to raise this question too :)

[Boshen]

Yeah this doesn't work, we need to check for symbols flags.

[camc314]

Yeah this doesn't work, we need to check for symbols flags.
we'd need multi-file analysis for this right?
we'd effectivly have to load in all of node_modules/and search through source for any global decls and get the symbol flags correct?

[Spoutnik97]

Yeah this doesn't work, we need to check for symbols flags.

@Boshen How do you recommend me to do that ?

[camc314]

yeah not sure there's a trivial fix for this.
i don't think this rule is recommended for TS files really

[Spoutnik97]

Yes indeed! Maybe it is not relevant to fix this bug, knowing that if the file is a ts file, then typescript will catch the error before ESLint.

Imo, it is only relevant for JavaScript, isn't it ?

[camc314]

yeah probably only relevant for JS files.
this may still produce false positives in JS files (e.g. global defined in one but referenced in another)