-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(prettier): Refactor IR related macros #7491
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
@Boshen Can I understand this to mean that I can merge PRs without review? |
CodSpeed Performance ReportMerging #7491 will not alter performanceComparing Summary
|
Although I ban macros in the rest of the codebase, I allow in this crate to make code easier to read. So the general guideline is:
|
Or use graphite to stack the PRs, whatever makes you productive. I can review after merge. |
Merge activity
|
- Remove `format!` macro - Rename string related macros, `&'static`: `text!` and `'a`: `dynamic_text!` - Apply `wrap!` macro instead of manually using `enter|leave_node` - Introduce `/ir` directory and move `Doc`, `impl Display`, `DocBuilder`, etc. I'm not yet determined how to, how deep to use macro, but this is first stepping stone... 🥌
- Remove `format!` macro - Rename string related macros, `&'static`: `text!` and `'a`: `dynamic_text!` - Apply `wrap!` macro instead of manually using `enter|leave_node` - Introduce `/ir` directory and move `Doc`, `impl Display`, `DocBuilder`, etc. I'm not yet determined how to, how deep to use macro, but this is first stepping stone... 🥌
format!
macro&'static
:text!
and'a
:dynamic_text!
wrap!
macro instead of manually usingenter|leave_node
/ir
directory and moveDoc
,impl Display
,DocBuilder
, etc.I'm not yet determined how to, how deep to use macro, but this is first stepping stone... 🥌