Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): minimize Infinity.toString(radix) to 'Infinity' #8732

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 26, 2025

No description provided.

Copy link
Member Author

Boshen commented Jan 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen changed the base branch from 01-26-feat_minifier_nan.tostring_radix_is_always_nan_ to graphite-base/8732 January 26, 2025 10:38
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 26, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 26, 2025
Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #8732 will not alter performance

Comparing 01-26-feat_minifier_minimize_infinity.tostring_radix_to_infinity_ (ff4e23f) with main (e0117db)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/8732 to main January 26, 2025 11:02
Copy link

graphite-app bot commented Jan 26, 2025

Merge activity

  • Jan 26, 6:03 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 26, 2025
@Boshen Boshen force-pushed the 01-26-feat_minifier_minimize_infinity.tostring_radix_to_infinity_ branch from 504c543 to 4f09551 Compare January 26, 2025 12:40
@Boshen Boshen force-pushed the 01-26-feat_minifier_minimize_infinity.tostring_radix_to_infinity_ branch from 4f09551 to ff4e23f Compare January 26, 2025 14:06
@Boshen Boshen merged commit 29bd215 into main Jan 26, 2025
27 checks passed
@Boshen Boshen deleted the 01-26-feat_minifier_minimize_infinity.tostring_radix_to_infinity_ branch January 26, 2025 14:14
Boshen added a commit that referenced this pull request Jan 26, 2025
## [0.48.1] - 2025-01-26

### Features

- b7f13e6 ast: Implement utf8 to utf16 span converter (#8687) (Boshen)
- 6589c3b mangler: Reuse variable names (#8562) (翠 / green)
- 29bd215 minifier: Minimize `Infinity.toString(radix)` to `'Infinity'`
(#8732) (Boshen)
- e0117db minifier: Replace `const` with `let` for non-exported
read-only variables (#8733) (sapphi-red)
- 9e32f55 minifier: Evaluate `Math.sqrt` and `Math.cbrt` (#8731)
(sapphi-red)
- 360d49e minifier: Replace `Math.pow` with `**` (#8730) (sapphi-red)
- 2e9a560 minifier: `NaN.toString(radix)` is always `NaN` (#8727)
(Boshen)
- cbe0e82 minifier: Minimize `foo(...[])` -> `foo()` (#8726) (Boshen)
- e9fb5fe minifier: Dce pure expressions such as `new Map()` (#8725)
(Boshen)

### Bug Fixes

- 0944758 codegen: Remove parens from `new (import(''), function() {})`
(#8707) (Boshen)
- 33de70a mangler: Handle cases where a var is declared in a block scope
(#8706) (翠 / green)
- d982cdb minifier: `Unknown.fromCharCode` should not be treated as
`String.fromCharCode` (#8709) (sapphi-red)
- e7ab96c transformer/jsx: Incorrect `isStaticChildren` argument for
`Fragment` with multiple children (#8713) (Dunqing)
- 3e509e1 transformer/typescript: Enum merging when same name declared
in outer scope (#8691) (branchseer)

### Performance

- dc0b0f2 manger: Remove useless `tmp_bindings` (#8735) (Dunqing)
- e472ced mangler: Optimize handling of collecting lived scope ids
(#8724) (Dunqing)
- 8587965 minifier: Normalize `undefined` to `void 0` before everything
else (#8699) (Boshen)

### Refactor

- 58002e2 ecmascript: Remove the lifetime annotation on
`MayHaveSideEffects` (#8717) (Boshen)
- 10e5920 linter: Move finishing default diagnostic message to
`GraphicalReporter` (#8683) (Sysix)
- 52a37d0 mangler: Simplify initialization of `slots` (#8734) (Dunqing)
- 6bc906c minifier: Allow mutating arguments in methods called from
`try_fold_known_string_methods` (#8729) (sapphi-red)
- bf8be23 minifier: Use `Ctx` (#8716) (Boshen)
- 0af0267 minifier: Side effect detection needs symbols resolution
(#8715) (Boshen)
- 32e0e47 minifier: Clean up `Normalize` (#8700) (Boshen)
- c792068 semantic: Simplify `ScopeTree::iter_bindings` (#8723)
(Dunqing)

### Testing

- 03229c5 minifier: Fix broken tests (#8722) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants