feat(minifier): compress a == null && b to a ?? b when return value is ignored
#8749
+77
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-minifier
CodSpeed Performance ReportMerging #8749 will not alter performanceComparing Summary
|
Merge activity
|
…ue is ignored (#8749) Compress `a == null && b` to `a ?? b` when return value is ignored When `a` is `null` or `undefined`, `a == null && b` returns `b`. When `a` is not `null` or `undefined`, `a == null && b` returns `false`. When `a` is `null` or `undefined`, `a ?? b` returns `b`. When `a` is not `null` or `undefined`, `a ?? b` returns `a`. **References** - [Spec of `??`](https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-binary-logical-operators-runtime-semantics-evaluation)
Boshen
force-pushed
the
01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_
branch
from
8a64c58 to
3c1c92c
Compare
Boshen
force-pushed
the
01-27-feat_minifier_compress_a_null_b_to_a_b_when_return_value_is_ignored
branch
from
2ff3de0 to
f7f2d2f
Compare
Base automatically changed from
01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_
to
main
January 27, 2025 14:38
graphite-app
bot
deleted the
01-27-feat_minifier_compress_a_null_b_to_a_b_when_return_value_is_ignored
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compress
a == null && btoa ?? bwhen return value is ignoredWhen
aisnullorundefined,a == null && breturnsb.When
ais notnullorundefined,a == null && breturnsfalse.When
aisnullorundefined,a ?? breturnsb.When
ais notnullorundefined,a ?? breturnsa.References
??