Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(minifier): cleanup some tests in minimize_conditions #8752

Conversation

sapphi-red
Copy link
Contributor

No description provided.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 27, 2025
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #8752 will not alter performance

Comparing 01-27-test_minifier_cleanup_some_tests_in_minimize_conditions (e78e468) with main (ad14403)

Summary

✅ 33 untouched benchmarks

@sapphi-red sapphi-red force-pushed the 01-27-test_minifier_cleanup_some_tests_in_minimize_conditions branch from d88552f to 7ecbd10 Compare January 27, 2025 12:56
@sapphi-red sapphi-red marked this pull request as ready for review January 27, 2025 13:07
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 27, 2025
Copy link
Member

Boshen commented Jan 27, 2025

Merge activity

  • Jan 27, 9:25 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 27, 9:25 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 27, 9:55 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 01-27-test_minifier_cleanup_some_tests_in_minimize_conditions branch from 7ecbd10 to e78e468 Compare January 27, 2025 14:47
@graphite-app graphite-app bot merged commit e78e468 into main Jan 27, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-27-test_minifier_cleanup_some_tests_in_minimize_conditions branch January 27, 2025 14:55
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants