Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(minifier): add and enable some tests in fold_constants #8769

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Jan 28, 2025

Ported some tests that was missing from closure compiler.
Also enabled some tests.

@github-actions github-actions bot added A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 28, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review January 28, 2025 12:08
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 28, 2025
Copy link
Member

Boshen commented Jan 28, 2025

Merge activity

  • Jan 28, 7:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 28, 7:16 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 28, 7:25 AM EST: A user merged this pull request with the Graphite merge queue.

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #8769 will degrade performances by 3.21%

Comparing 01-28-test_minifier_add_and_enable_some_tests_in_fold_constants (79d5481) with main (8cf9d34)

Summary

❌ 1 regressions
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
semantic[cal.com.tsx] 25.9 ms 26.8 ms -3.21%

Ported some tests that was missing from closure compiler.
Also enabled some tests.
@Boshen Boshen force-pushed the 01-28-test_minifier_add_and_enable_some_tests_in_fold_constants branch from e2b8f9d to 79d5481 Compare January 28, 2025 12:18
@graphite-app graphite-app bot merged commit 79d5481 into main Jan 28, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-28-test_minifier_add_and_enable_some_tests_in_fold_constants branch January 28, 2025 12:25
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants