feat(mangler): use characters in the order of their likely frequency #8771
+118
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
sapphi-red
force-pushed
the
01-29-feat_mangler_use_characters_in_the_order_of_their_likely_frequency
branch
from
d6180da to
94784df
Compare
CodSpeed Performance ReportMerging #8771 will not alter performanceComparing Summary
|
sapphi-red
force-pushed
the
01-29-feat_mangler_use_characters_in_the_order_of_their_likely_frequency
branch
from
94784df to
810f3ac
Compare
sapphi-red
commented
Jan 28, 2025
|
Smart! |
Merge activity
|
…8771) Just noticed that we can use a static list here. I think this has no downsides. To have better compression, we can actually count the characters, but I guess there won't be much difference normally.
Boshen
force-pushed
the
01-29-feat_mangler_use_characters_in_the_order_of_their_likely_frequency
branch
from
810f3ac to
86b6219
Compare
graphite-app
bot
deleted the
01-29-feat_mangler_use_characters_in_the_order_of_their_likely_frequency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that we can use a static list here. I think this has no downsides. To have better compression, we can actually count the characters, but I guess there won't be much difference normally.