Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(codegen): avoid a heap allocation when printing floats #8807

Merged
merged 1 commit into from
Jan 31, 2025
Merged

perf(codegen): avoid a heap allocation when printing floats #8807

merged 1 commit into from
Jan 31, 2025
+19 −16

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 31, 2025

No description provided.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-codegen Area - Code Generation C-performance Category - Solution not expected to change functional behavior, only performance labels Jan 31, 2025
@Boshen Boshen marked this pull request as draft January 31, 2025 08:26
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 31, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8807 will not alter performance

Comparing print-num (d8fac6d) with main (f8548ec)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen force-pushed the print-num branch 3 times, most recently from 2e7a1c2 to d44462a Compare January 31, 2025 08:40
@Boshen Boshen marked this pull request as ready for review January 31, 2025 08:48
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jan 31, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 31, 3:48 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 3:48 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 31, 3:53 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot merged commit d8fac6d into main Jan 31, 2025
26 checks passed
@graphite-app graphite-app bot deleted the print-num branch January 31, 2025 08:53
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen