refactor(ast): make generated code for Visit more understandable
#8825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-ast
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Small refactor only, and preparatory work for a much larger change, so merging without review. |
Merge activity
|
…8825) Pure refactor. `for elements in it.elements.iter().flatten()` doesn't make much sense - each item is a single element, not multiple elements. Change to `for el in it.elements.iter().flatten()`.
graphite-app
bot
force-pushed
the
02-01-refactor_ast_make_generated_code_for_visit_more_understandable
branch
from
03a6845 to
30eec26
Compare
graphite-app
bot
deleted the
02-01-refactor_ast_make_generated_code_for_visit_more_understandable
branch
CodSpeed Performance ReportMerging #8825 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor.
for elements in it.elements.iter().flatten()doesn't make much sense - each item is a single element, not multiple elements. Change tofor el in it.elements.iter().flatten().