Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecmascript): complete may_have_side_effects #8855

Merged

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Feb 3, 2025

Ported tests from closure compiler and reviewed the behavior of may_have_side_effects and added additional tests.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Feb 3, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8855 will not alter performance

Comparing 02-03-feat_ecmascript_complete_may_have_side_effects (e3e9999) with main (a302e32)

Summary

✅ 33 untouched benchmarks

@sapphi-red sapphi-red marked this pull request as ready for review February 3, 2025 14:20
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the request changes :-(

This creates a cyclic dependency with oxc_parser (an unfortunate cargo limitation). This is why all the tests are in oxc_minifier :-(

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the request changes :-(

This creates a cyclic dependency with oxc_parser (an unfortunate cargo limitation). This is why all the tests are in oxc_minifier :-(

@sapphi-red sapphi-red force-pushed the 02-03-feat_ecmascript_complete_may_have_side_effects branch from 3fac764 to 7069149 Compare February 4, 2025 03:06
@sapphi-red sapphi-red requested a review from Boshen February 4, 2025 07:14
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link
Member

Boshen commented Feb 4, 2025

Merge activity

  • Feb 4, 10:49 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 4, 10:49 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 4, 10:54 AM EST: A user merged this pull request with the Graphite merge queue.

Ported tests from closure compiler and reviewed the behavior of may_have_side_effects and added additional tests.
@graphite-app graphite-app bot force-pushed the 02-03-feat_ecmascript_complete_may_have_side_effects branch from b023ac2 to e3e9999 Compare February 4, 2025 15:49
@graphite-app graphite-app bot merged commit e3e9999 into main Feb 4, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_ecmascript_complete_may_have_side_effects branch February 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants