-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecmascript): complete may_have_side_effects #8855
feat(ecmascript): complete may_have_side_effects #8855
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8855 will not alter performanceComparing Summary
|
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the request changes :-(
This creates a cyclic dependency with oxc_parser (an unfortunate cargo limitation). This is why all the tests are in oxc_minifier :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the request changes :-(
This creates a cyclic dependency with oxc_parser (an unfortunate cargo limitation). This is why all the tests are in oxc_minifier :-(
3fac764
to
7069149
Compare
Merge activity
|
Ported tests from closure compiler and reviewed the behavior of may_have_side_effects and added additional tests.
b023ac2
to
e3e9999
Compare
Ported tests from closure compiler and reviewed the behavior of may_have_side_effects and added additional tests.