Make Signer optional & make ecdsa_util.h private #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- oxen-core doesn't need ethyl's Signer class at all, so add an option to allow disabling it (so that we can also avoid unnecessarily dependency or embedded libsecp256k1 in oxen-core). - ecdsa_util.h is a private implementation header not meant to be installed with the main ethyl includes, so move it to src/ instead. - remove unused "headers" variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secp256k1 in particular is a problem because it likes to inject compiler arguments that don't actually work (particularly on Ubuntu focal). Since we don't seem to need the signing capability outside test suites (ethyl's own, and eth-sn-contracts), this allows disables building it so that we can avoid the secp256k1 dependency for oxen-core.