chore: address PR reviews

oxen-io · Sep 24, 2024 · 3df534f · 3df534f
1 parent f2b1246
commit 3df534f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml
@@ -55,7 +55,7 @@ jobs:
         # no need to dedup yarn.lock on all platforms
         uses: ./actions/deduplicate_fail
 
-        # we want to test on all platforms are some are testing the menus rendered (and are depent on the platform)
+        # we want to test on all platforms since some are testing the rendered menus (and are dependent on the platform)
       - name: Unit Test
         run: yarn test
 
@@ -93,7 +93,7 @@ jobs:
         with:
           cache_suffix: 'windows_x64'
 
-        # we want to test on all platforms are some are testing the menus rendered (and are depent on the platform)
+        # we want to test on all platforms since some are testing the rendered menus (and are dependent on the platform)
       - name: Unit Test
         run: yarn test
 
@@ -136,7 +136,7 @@ jobs:
         with:
           cache_suffix: 'macos_x64'
 
-        # we want to test on all platforms are some are testing the menus rendered (and are depent on the platform)
+        # we want to test on all platforms since some are testing the rendered menus (and are dependent on the platform)
       - name: Unit Test
         run: yarn test
 

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -274,3 +274,5 @@ You can build a production binary by running the following:
 yarn build-everything
 yarn build-release
 ```
+
+On linux, you can change in package.json `"target": ["deb"],` to any of the [electron-builder targets](https://www.electron.build/linux#target) to build for another target.
diff --git a/INTERNALBUILDS.md b/INTERNALBUILDS.md
@@ -146,3 +146,5 @@ yarn build-release
 ```
 
 The binaries will be placed inside the `release/` folder.
+
+On linux, you can change in package.json `"target": ["deb"],` to any of the [electron-builder targets](https://www.electron.build/linux#target) to build for another target.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -146,3 +146,5 @@ yarn build-release
		```

		The binaries will be placed inside the `release/` folder.

		On linux, you can change in package.json `"target": ["deb"],` to any of the [electron-builder targets](https://www.electron.build/linux#target) to build for another target.