forked from signalapp/Signal-iOS
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.6.2 fixes #986
Merged
Merged
Version 2.6.2 fixes #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Fixed an issue where the notification extension could end up in an invalid state if you delete and create a new account in rapid succession • Fixed an issue where notification processing errors weren't getting handled correctly resulting in the notification extension timing out • Stopped the notification extension from trying to download profile images • Added commit hash to version info • Tweaked the notification extension logic flow to be more straight forward
• Tweaked the message request notification behaviour • Fixed an issue where duplicate message errors would result in the generic notification being shown • Further notification logging improvements
• Fixed an issue where leaving and returning to the app rapidly could leave the app in a state when the database and network are inaccessible • Fixed an issue where bad nodes might not get dropped from the pool (libSession update)
3 tasks
• Fixed an issue where the default log level was set too low • Fixed an issue where sending the app to the background without any pending jobs could result in the database and network not being suspended correctly • Updated to latest libSession (don't try to recover paths, just rebuild)
• Added a method to customise mock parameter summaries for unit tests • Pulled across the updated libSession cache logic
RyanRory
reviewed
Jul 1, 2024
RyanRory
approved these changes
Jul 1, 2024
• Fixed an issue where excessive job failures could result in jobs not running onLaunch or onActive as expected (extended network issues resulted in the default communities not getting fetched) • Fixed an issue where the PathVC could end up in a weird state after the IP2Country cache gets updated • Fixed an issue where LinkPreview caching was incorrectly case sensitive • Fixed an issue where the IP2Country might load it's cache on the wrong thread • Added the ability to copy the file path to the log file when exporting on the simulator • Updated the Request type to correctly encode a body of 'Data' type when given (would previously incorrectly encode it as JSON)
• Updated the GeoLite2 country database data, added some basic localisation to it • Managed to optimise the size of the GeoLite2 data bundled with the app (10mb -> 8mb) • Cleaned up the IP2Country logic a little • Removed some pluralisation from logs (want the logs to be identical outside of numbers) • Tweaked the PushRegistrationManager to actually timeout
• Updated the pollers to NOT take the duration of the previous poll into account when scheduling the next poll • Updated to the latest `libSession` version (a few optimisations/fixes) • Fixed a minor layout issue with the attribution label on the Path screen
• Fixed an issue where the BackgroundPoller would fail if a single destination failed - This would suspend the network, then the other pending requests would error and automatically retry, attempting to create a new connection which could loop a number of times rapidly since the network was suspended • Fixed an issue where the BackgroundPoller could incorrectly try to write to the database after it had been suspended
RyanRory
approved these changes
Jul 19, 2024
# Conflicts: # Session/Meta/AppDelegate.swift # Session/Onboarding/LandingVC.swift # Session/Onboarding/LinkDeviceVC.swift # Session/Onboarding/RegisterVC.swift # Session/Onboarding/RestoreVC.swift
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackgroundPoller
would fail if a single destination failedBackgroundPoller
could incorrectly try to write to the database after it had been suspended