Add multi part #716
Merged
Add multi part #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, @jessfraz--might take us a little bit as we're in crunch time over here; apologies in advance for any delay |
|
@ahl understandable! If it helps I figured you all would likely need this for a blob storage api or if you allow customers to upload their own isos to boot in vms :) |
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
adamchalmers
force-pushed
the
add-multi-part
branch
from
04ac08a
to
3362a58
Compare
|
Merge conflicts fixed! |
The test for multipart didn't actually get a second part of the body, it just got the first one. The test now concatenates all body parts, so it should check some boundary conditions. According to `cargo llvm-cov` this increases test coverage of body.rs by 2 percent.
|
@adamchalmers are you folks on the same page with regard to your comments above? |
|
Yeah, I updated the tests to increase the coverage. Not really sure if we keep the Copyright Oxide header on test_multipart.rs but I also don't really care! Jess and I spoke last night and we're on the same page. |
|
LGTM thanks! |
|
<3 Thanks y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
multipart/form-data. Thanks! Let me know if you want anything to be changed but it came out super clean, better than I expected. Added tests as well :)ping @ahl @davepacheco