Fix off-by-one-error in RoT caboose reading (#1436)

oxidecomputer · Jun 27, 2023 · ec0b7fe · ec0b7fe
1 parent 31dac53
commit ec0b7fe
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drv/lpc55-update-server/src/main.rs b/drv/lpc55-update-server/src/main.rs
@@ -262,7 +262,7 @@ impl idl::InOrderUpdateImpl for ServerImpl<'_> {
         data: Leased<idol_runtime::W, [u8]>,
     ) -> Result<(), RequestError<RawCabooseError>> {
         let caboose = caboose_slice(&self.flash, slot)?;
-        if offset as usize + data.len() >= caboose.len() {
+        if offset as usize + data.len() > caboose.len() {
             return Err(RawCabooseError::InvalidRead.into());
         }
         copy_from_caboose_chunk(