dice-mfg: allow querying secure boot key slot status #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
approved these changes
Aug 8, 2023
Comment on lines
+313
to
+326
| #[derive(FromBytes)] | ||
| #[repr(C)] | ||
| struct CfpaPage { | ||
| // Fields defined by NXP: | ||
| header: u32, | ||
| monotonic_version: u32, | ||
| _fields_we_do_not_use: [u32; 4], | ||
| rotkh_revoke: u32, | ||
| _more_fields_we_do_not_use: [u32; 5], | ||
| _prince_ivs: [[u32; 14]; 3], | ||
| _nxp_reserved: [u32; 10], | ||
| _customer_area: [u8; 224], | ||
| _digest: [u8; 32], | ||
| } |
There was a problem hiding this comment.
ugh I really wish we had this accessible in another crate but I don't have a better idea at the moment.
|
I dug out my local mfg setup yesterday evening and gave this a test (it worked as expected). I'm going to test a few additional configurations but will be merging this first. |
flihp
approved these changes
Aug 8, 2023
|
Almost forgot that this PR needs an update to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by modifying lpc55expresso to use dice-mfg, flashing to lpc55xpresso w/ secure boot enabled, and running
dice-mfg get-key-slot-status(from oxidecomputer/dice-util#88) which reported all slots enabled as expected.Depends on oxidecomputer/dice-util#88 so CI will fail until that is merged.