Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply with MessageKind::Error when reporting an error #1444

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Reply with MessageKind::Error when reporting an error #1444

merged 1 commit into from
Jun 27, 2023

Conversation

mkeeter
Copy link
Collaborator

@mkeeter mkeeter commented Jun 27, 2023

Otherwise, we copy MessageKind::HostToSp from the header, which makes the host mad.

@mkeeter mkeeter mentioned this pull request Jun 27, 2023
Merged
Aaron-Hartwig
Aaron-Hartwig approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@Aaron-Hartwig Aaron-Hartwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mkeeter mkeeter merged commit 8d74b15 into master Jun 27, 2023
@mkeeter mkeeter deleted the fix-reply-type branch June 27, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaron-Hartwig Aaron-Hartwig Aaron-Hartwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkeeter @Aaron-Hartwig