Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name for tests workflow #1481

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Add name for tests workflow #1481

merged 1 commit into from
Aug 8, 2023

Conversation

mkeeter
Copy link
Collaborator

@mkeeter mkeeter commented Aug 8, 2023

For some reason, you need a secondary name for this check to show up as a branch protection option.

(I also decapitalized "Tests" to match our other CI workflows)

@mkeeter mkeeter requested a review from labbott August 8, 2023 13:28
@@ -11,9 +11,8 @@ env:

jobs:
build:

name: tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to bikeshed this to death but "hubris-tests" might be more specific. Up to you if you think we're likely to grow other tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I think this is fine for now since all the other CI steps are also short (dist, formatting, documentation)

@mkeeter mkeeter enabled auto-merge (squash) August 8, 2023 13:34
@mkeeter mkeeter merged commit 3fb145e into master Aug 8, 2023
66 checks passed
@mkeeter mkeeter deleted the update-actions branch August 8, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants