Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ringbuf: make macros vestigial #1753

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ringbuf: make macros vestigial #1753

wants to merge 1 commit into from

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Apr 17, 2024


/!\ EXTREMELY SERIOUS WARNING /!\
This will break Humility. Eliza, REMEMBER TO
UPDATE HUMILITY if you end up merging
this PR!!!!


This branch makes the ringbuf crate usable without macros. Now, the macros are just very thin wrappers around Ringbuf::new() const fn constructors and __RINGBUF.record(entry), respectively. The idea being that, should we decide this is worth doing, we could then incrememtally replace the uses of macros with normal method calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant