-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cleanup remaining userlib namespace imports #1857
base: master
Are you sure you want to change the base?
chore: Cleanup remaining userlib namespace imports #1857
Conversation
@@ -923,7 +923,7 @@ impl I2cController<'_> { | |||
|
|||
#[rustfmt::skip] | |||
i2c.oar1.modify(|_, w| { w | |||
.oa1en().clear_bit() // own-address disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Zed editor did these format fixes automatically, so they're kind of "slipping in" on the side.
@cbiffle My apologies for the ping: Would you be amenable to taking a look at this? All CI tests have been fully green, only |
633adda
to
c453676
Compare
The remaining lpc55xpresso Though oops, I only now actually checked whether |
This PR ends my work of walking through the hubris code base, removing userlib namespace imports.
This time I did a search-and-replace on all of these to clear them out. I currently see some build issue about notifications with
app/lpc55xpresso/app-sprot.toml
; how thenotifications
should get built is not quite clear to me.Another interesting file is
task/template/src/main.rs
where we have this comment:I'm not sure if I should add some imports here or not.