Include the Hubris measurement in DICE #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzrd
force-pushed
the
dice-hubris-fwid
branch
from
3770310
to
5384ced
Compare
lzrd
force-pushed
the
dice-hubris-fwid
branch
from
5384ced
to
9949964
Compare
labbott
reviewed
Sep 13, 2024
| @@ -201,6 +184,30 @@ pub fn startup( | |||
| panic!(); | |||
| }; | |||
|
|
|||
| #[cfg(any(feature = "dice-mfg", feature = "dice-self"))] | |||
There was a problem hiding this comment.
I might make a separate change to drop this cfg check as all our RoT targets now enable one of dice-mfg or dice-self
labbott
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the Hubris measurement in DICE even though it is done in Hubris pre-main.