Upgrade clap to 3.2.5 #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clap 3.2 is the last release before 4.0: https://epage.github.io/blog/2022/06/clap-32-last-call-before-40/ These changes upgrade our usage of features that are being deprecated, insuring that we shall have an easy upgrade path to 4.0. The two biggest changes: 1. removing NoAutoVersion. 2. changing our usage of parse_int::parse to the new value_parser API Big thanks to @epage for helping out with 2: clap-rs/clap#3839 And for working through some error messages: clap-rs/clap#3822 As for NoAutoVersion, opting into the new behavior via `action` does what we want, *except* that the output for doing it with another incorrect flag doesn't give the error about how that's incorrect. I suspect that this is an acceptable change in behavior, but worth calling out. You can see the difference in the chip.trycmd tests.
steveklabnik
commented
Jun 16, 2022
epage
added a commit
to epage/clap
that referenced
this pull request
Jun 16, 2022
This was an oversight when listing out the options as identified when looking at oxidecomputer/humility#161.
steveklabnik
force-pushed
the
upgrade-clap
branch
from
b21064d to
8859ce6
Compare
Merged
|
This is so out of date that if I pursue this again in the future I'll have to re-do it from scratch anyway, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap 3.2 is the last release before 4.0:
https://epage.github.io/blog/2022/06/clap-32-last-call-before-40/
These changes upgrade our usage of features that are being deprecated,
insuring that we shall have an easy upgrade path to 4.0.
The two biggest changes:
Big thanks to @epage for helping out with 2:
clap-rs/clap#3839
And for working through some error messages:
clap-rs/clap#3822
As for NoAutoVersion, opting into the new behavior via
actiondoeswhat we want, except that the output for doing it with another
incorrect flag doesn't give the error about how that's incorrect. I
suspect that this is an acceptable change in behavior, but worth calling
out. You can see the difference in the chip.trycmd tests.