Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move away from nocrypto #563

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat: move away from nocrypto #563

merged 2 commits into from
Nov 20, 2023

Conversation

leostera
Copy link
Contributor

See #562.

@leostera leostera mentioned this pull request Nov 17, 2023
Merged
@joseferben
Copy link
Contributor

lgtm, thanks for the pr!

@joseferben
Copy link
Contributor

[exception] The default generator is not yet initialized. has the api changed for initialization?

@leostera
Copy link
Contributor Author

Yup, my bad! I'll amend this.

@leostera
Copy link
Contributor Author

@joseferben hi! 👋🏼 Just pushed the last fix. Managed to get all the tests passing locally too :)

@leostera leostera mentioned this pull request Nov 20, 2023
Merged
@joseferben joseferben merged commit 56ce27c into oxidizing:master Nov 20, 2023
1 check passed
@joseferben
Copy link
Contributor

looks good, thank you @leostera

@joseferben joseferben mentioned this pull request Nov 20, 2023
Closed
@leostera leostera deleted the mirage-crypto branch November 21, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseferben joseferben joseferben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leostera @joseferben