-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Optimal Sugiyama Layout #4
Conversation
Files missing from main
…ions are equally good)
Oooh, that looks amazing. Thanks for pinging! |
@daschw for a Sankey diagram should the weights control the distance during arrangement, or just how hard to try for different overlapping line-crossings during ordering? Currently it does both. |
Oh wow my git settings are a total mess |
I added checking for multiple solutions. It doesn't find many that are better than but does find some that are better in the like 10^-7 order or something. |
Sorry, I missed this question. Looking at e.g. https://observablehq.com/@d3/sankey-diagram it does not seem like the weights impact the distance. It rather looks the maximum yaxis range is minimized. |
Cool, if we remove the weighting from that step then that is what we will have. |
I think this basically done. |
Probably the images are slightly different because there are multiple equivelent solutions.
For some reason coveralls is failing to upload but tests are passing |
I finally managed to continue work on this : https://github.com/daschw/SankeyPlots.jl |
I am actually working more off this paper
https://ialab.it.monash.edu/~dwyer/papers/optimal-sankey-diagrams.pdf
so perhaps it should be a ZarateLayout ?
TODO
Also supports weights for crossings so should be perfect for Sankey
(cc @daschw)