Removing kmer records #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
reviewed
Sep 17, 2024
src/lib.rs
Outdated
| )) | ||
| } else { | ||
| // Compute the hash of the k-mer using the same method used for counting | ||
| let hashval = self.hash_kmer(kmer).unwrap(); |
There was a problem hiding this comment.
you can replace the if/else with just
let hashval = self.hash_kmer(kmer)?;
which will forward the Err up the call stack. (I know I didn't do that elsewhere, not sure why ;)
There was a problem hiding this comment.
That makes sense. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods for removing specific kmers and for thresholding on counts.
drop(): Remove record from count table by kmer.drop_hash(): Remove record from table by hash.mincut(): Remove all records with counts less than x.maxcut(): Remove all records with counts greater than x.Closes #18
Closes #19