Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage #88

Merged

Conversation

itayox
Copy link
Contributor

@itayox itayox commented Aug 15, 2023

image

@itayox itayox linked an issue Aug 15, 2023 that may be closed by this pull request
@itayox itayox requested a review from nvuillam August 15, 2023 15:40
@itayox itayox self-assigned this Aug 15, 2023
@itayox itayox requested a review from eyalatox August 15, 2023 15:40
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 6 3 0.12s
✅ COPYPASTE jscpd yes no 3.99s
⚠️ CSS stylelint 3 0 1 1.11s
✅ DOCKERFILE hadolint 1 0 0.11s
✅ HTML djlint 1 0 0.65s
✅ HTML htmlhint 1 0 0.24s
✅ JSON eslint-plugin-jsonc 19 0 0 1.96s
✅ JSON jsonlint 19 0 0.18s
✅ JSON npm-package-json-lint yes no 0.61s
✅ JSON prettier 19 0 0 1.31s
✅ JSON v8r 19 0 18.71s
⚠️ MARKDOWN markdownlint 10 0 31 1.3s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.37s
✅ REPOSITORY checkov yes no 23.02s
✅ REPOSITORY gitleaks yes no 2.64s
✅ REPOSITORY git_diff yes no 0.18s
✅ REPOSITORY grype yes no 9.81s
⚠️ REPOSITORY kics yes 1 18.31s
✅ REPOSITORY secretlint yes no 2.01s
✅ REPOSITORY trivy yes no 4.84s
✅ REPOSITORY trivy-sbom yes no 0.97s
✅ REPOSITORY trufflehog yes no 3.39s
✅ SPELL cspell 56 0 4.08s
✅ SPELL lychee 43 0 2.8s
✅ YAML prettier 11 0 0 0.69s
✅ YAML v8r 11 0 15.12s
✅ YAML yamllint 11 0 0.49s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

nvuillam
nvuillam previously approved these changes Aug 15, 2023
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@nvuillam
Copy link
Member

@itayox there is a failing test in Build CI job :/

@nvuillam nvuillam dismissed their stale review August 15, 2023 17:12

Didn't see the failing test case

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you make the build CI job work ? ( there is a failing test case)

@itayox
Copy link
Contributor Author

itayox commented Aug 16, 2023

Fixing it 👍

@itayox itayox requested a review from nvuillam August 16, 2023 11:46
@itayox
Copy link
Contributor Author

itayox commented Aug 16, 2023

@nvuillam Fixed :)

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@nvuillam nvuillam merged commit 407833a into main Aug 17, 2023
3 checks passed
@nvuillam nvuillam deleted the 87-add-unit-tests-to-register-routes-and-start-http-server branch August 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests to "register routes" and "start http server"
2 participants