Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP_PSALM linter environment #3538

Closed
llaville opened this issue May 4, 2024 · 3 comments · Fixed by #3541
Closed

Update PHP_PSALM linter environment #3538

llaville opened this issue May 4, 2024 · 3 comments · Fixed by #3541
Assignees
Labels
enhancement New feature or request

Comments

@llaville
Copy link
Collaborator

llaville commented May 4, 2024

Is your feature request related to a problem? Please describe.
It's not a problem. We should consider as an improvement for the PHP_PSALM linter configuration.

Describe the solution you'd like

Describe alternatives you've considered
Keep configuration in state

Additional context
E.g: Report produced by scanning megalinter/.automation/test/php directory of this repo !

[psalm] command: ['psalm', '--output-format=console', '--config=/action/lib/.automation/psalm.xml', 'php_bad_1.php', 'php_bad_2.php', 'php_good_1.php', 'php_good_2.php']
[psalm] CWD: /tmp/lint
[psalm] result: 2 Warning: "findUnusedBaselineEntry" will default to "true" in Psalm 6. You should explicitly enable or disable this setting.
Warning: "findUnusedCode" will default to "true" in Psalm 6. You should explicitly enable or disable this setting.

Install the opcache extension to make use of JIT on PHP 8.0+ for a 20%+ performance boost!

Target PHP version: 8.3 (inferred from current PHP version).
Scanning files...
Analyzing files...

@llaville llaville added the enhancement New feature or request label May 4, 2024
@llaville llaville self-assigned this May 4, 2024
@llaville
Copy link
Collaborator Author

llaville commented May 4, 2024

New branch features/php-psalm-improvement available with updates : 067b070

@llaville
Copy link
Collaborator Author

llaville commented May 4, 2024

Spell Linter is a bit rough when new word is not in is dictionary :
trivy_secret-psalm

@llaville
Copy link
Collaborator Author

llaville commented May 5, 2024

cspell issue fixed by new commit a940b87

llaville added a commit that referenced this issue May 5, 2024
nvuillam pushed a commit that referenced this issue May 5, 2024
* implement PHP_PSALM linter config improvement (see feature request #3538)

* fix cspell linter dict about unknown word 'opcache'

* update changelog about feature #3538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant