Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reporter text for better UX #2168

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Change reporter text for better UX #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reporters/TextReporter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Posts a pack of text logs , zipped as a GitHub Action artifact

### Get Artifacts on GitLab CI

- Access GitLabel CI job page
- Access GitLab CI job page

![Screenshot](../assets/images/TextReporter_gitlab_1.jpg)

Expand Down
4 changes: 2 additions & 2 deletions megalinter/reporters/GitlabCommentReporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ def produce_report(self):
# Check if there is already a MegaLinter comment
for comment in existing_comments:
if (
"See errors details in [artifact MegaLinter reports on"
in comment.body
"See detailed report in [MegaLinter reports" in comment.body
or "See detailed report in MegaLinter reports" in comment.body
):
existing_comment = comment

Expand Down
6 changes: 3 additions & 3 deletions megalinter/utils_reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ def build_markdown_summary(reporter_self, action_run_url):
p_r_msg += table_content + os.linesep
if action_run_url != "":
p_r_msg += (
"See errors details in [artifact MegaLinter reports on "
f"CI Job page]({action_run_url})" + os.linesep
"See detailed report in [MegaLinter reports"
f"]({action_run_url})" + os.linesep
)
else:
p_r_msg += "See errors details in MegaLinter reports" + os.linesep
p_r_msg += "See detailed report in MegaLinter reports" + os.linesep
if reporter_self.master.validate_all_code_base is False:
p_r_msg += (
"_Set `VALIDATE_ALL_CODEBASE: true` in mega-linter.yml to validate "
Expand Down