Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet linters to .NET 8 #3182

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Update dotnet linters to .NET 8 #3182

merged 7 commits into from
Feb 12, 2024

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Dec 4, 2023

No description provided.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.02s
✅ BASH shellcheck 5 0 0.13s
✅ BASH shfmt 5 0 0 0.59s
✅ COPYPASTE jscpd yes no 4.34s
✅ DOCKERFILE hadolint 127 0 16.29s
✅ JSON eslint-plugin-jsonc 23 0 0 4.7s
✅ JSON jsonlint 21 0 0.34s
✅ JSON v8r 23 0 26.72s
✅ MAKEFILE checkmake 1 0 0.01s
⚠️ MARKDOWN markdownlint 261 0 265 33.43s
✅ MARKDOWN markdown-link-check 261 0 10.98s
✅ MARKDOWN markdown-table-formatter 261 0 0 142.18s
✅ OPENAPI spectral 1 0 1.49s
⚠️ PYTHON bandit 208 64 3.52s
✅ PYTHON black 208 0 0 6.04s
✅ PYTHON flake8 208 0 2.44s
✅ PYTHON isort 208 0 0 1.37s
✅ PYTHON mypy 208 0 16.32s
✅ PYTHON pylint 208 0 17.07s
⚠️ PYTHON pyright 208 352 27.85s
✅ PYTHON ruff 208 0 0 0.67s
✅ REPOSITORY checkov yes no 43.31s
✅ REPOSITORY git_diff yes no 0.57s
⚠️ REPOSITORY grype yes 1 25.26s
✅ REPOSITORY secretlint yes no 18.55s
✅ REPOSITORY trivy yes no 26.41s
✅ REPOSITORY trivy-sbom yes no 9.65s
⚠️ REPOSITORY trufflehog yes 1 11.83s
✅ SPELL cspell 683 0 29.31s
✅ SPELL lychee 341 0 8.24s
✅ XML xmllint 3 0 0 0.55s
✅ YAML prettier 160 0 0 6.69s
✅ YAML v8r 102 0 180.7s
✅ YAML yamllint 161 0 2.38s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 4, 2023

Fails with:

0.429 ERROR: unable to select packages:
0.429   dotnet8-sdk (no such package):
0.429     required by: world[dotnet8-sdk]

This page shows this warning, we will wait until it "fixes itself":

.NET 8 was released on November 14, 2023. It may take time for the packages to appear in the package manager feeds.

https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine

@echoix
Copy link
Collaborator

echoix commented Dec 4, 2023

Fails with:


0.429 ERROR: unable to select packages:

0.429   dotnet8-sdk (no such package):

0.429     required by: world[dotnet8-sdk]

This page shows this warning, we will wait until it "fixes itself":

.NET 8 was released on November 14, 2023. It may take time for the packages to appear in the package manager feeds.

https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine

Indeed, I don't see any dotnet8 packages in the alpine packages, even on edge. I thought I had seen them, but maybe it was only the Ms docs.

I think the note was for when the docs was released, since I see some that had the build date on the 16th

@echoix
Copy link
Collaborator

echoix commented Dec 4, 2023

At least if we have dotnet 7 in a first release it's already better

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 4, 2023

At least if we have dotnet 7 in a first release it's already better

I already predicted that something might happen and that's why I didn't mix PRs 🤣

#2402 (comment)

@nvuillam
Copy link
Member

nvuillam commented Dec 4, 2023

Let's quitely wait .net8 to be in alpine packages, I'm so glad we don't need to install it the messy way anymore ^^

@echoix
Copy link
Collaborator

echoix commented Dec 13, 2023

https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/49831

@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 5, 2024

It is still the same, I have reported it to see if I call attention and they can prioritize it: dotnet/sdk#37790

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 11, 2024

I forgot to mention it, but from what they say, until alpine 3.20 they will not include it: dotnet/sdk#37790 (comment)

@nvuillam
Copy link
Member

Is there a way to install it from the edge version meanwhile ?

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 12, 2024

@nvuillam at least I can't answer you, I have no experience with alpine and its packages.... But in case we can it would be the way to unblock this problem now and in the future because it can happen again with .NET 9...

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 12, 2024

Doing a quick search it looks like it is: https://stackoverflow.com/a/52903112

@nvuillam
Copy link
Member

@bdovaz if you want to try something like apk add librdkafka --repository=https://dl-cdn.alpinelinux.org/alpine/edge/community, it will work if you move it from the apk property to the dockerfile property :)

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 12, 2024

@nvuillam done!

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 12, 2024

@nvuillam ready!

@echoix
Copy link
Collaborator

echoix commented Feb 12, 2024

I think it's ok, since the tests pass. How breaking of a change is this to projects using Megalinter (estimated)?

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @bdovaz :)

@nvuillam nvuillam merged commit 5229364 into main Feb 12, 2024
130 checks passed
@nvuillam nvuillam deleted the features/net-8 branch February 12, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants