Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for blank cell type in addition to null check for mandatory cells #314

Conversation

virtual-machinist
Copy link
Contributor

This change adds a check if the cell is blank, i.e. is not missing / null, but having CellType.BLANK.

This improves mandatory cell check behavior as described in #311 , and blank cells in XLS files and opened XLS/XLSX sheets also throw a PoijiMultiRowException.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (0ee9a3f) to head (63d9c09).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
- Coverage     93.78%   93.63%   -0.16%     
+ Complexity      465      464       -1     
============================================
  Files            44       44              
  Lines          1304     1304              
  Branches        161      161              
============================================
- Hits           1223     1221       -2     
- Misses           45       47       +2     
  Partials         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virtual-machinist
Copy link
Contributor Author

Closing this, since will probably opt out for the better Row.MissingCellPolicy.RETURN_BLANK_AS_NULL option one way or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants