Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ-348: EIP Client made generic (OpenMRS-agnostic) + Upgrade to Java 17. #23

Merged
merged 9 commits into from
Jan 25, 2024
Merged

OZ-348: EIP Client made generic (OpenMRS-agnostic) + Upgrade to Java 17. #23

merged 9 commits into from
Jan 25, 2024

Conversation

corneliouzbett
Copy link
Contributor

@corneliouzbett corneliouzbett commented Nov 7, 2023 •
edited
Loading

Issue: https://mekomsolutions.atlassian.net/jira/software/c/projects/OZ/issues/OZ-348

In this PR, I have made several enhancements:

  • Upgraded the project to Java 17, leveraging its new features and performance improvements.
  • Refactored the EIP client to make it generic and remove the hard dependency on openmrs-watcher.
  • Optimized the Docker image using Spring Boot layered tools.
  • Enhanced the README documentation for better clarity and usage instructions.

@mks-d mks-d changed the title OZ-348: Upgrade to Java 17 and refactor EIP client to make it generic. OZ-348: EIP Client made generic (OpenMRS-agnostic) + Upgrade to Java 17. Nov 7, 2023
mks-d
mks-d reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mks-d mks-d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, by removing the openmrs-watcher dependency, this does not have to wait for EIP-133, correct?

@corneliouzbett
Copy link
Contributor Author

So, by removing the openmrs-watcher dependency, this does not have to wait for EIP-133, correct?

Yes.

This was referenced Jan 4, 2024
Merged
Merged
ibacher
ibacher approved these changes Jan 8, 2024
View reviewed changes
Copy link

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.

Dockerfile Outdated Show resolved Hide resolved
app/src/main/resources/assembly/assembly.xml Outdated Show resolved Hide resolved
Ruhanga
Ruhanga approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corneliouzbett corneliouzbett merged commit 4e27ca0 into ozone-his:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mks-d mks-d mks-d left review comments

@ibacher ibacher ibacher approved these changes

@Ruhanga Ruhanga Ruhanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corneliouzbett @mks-d @Ruhanga @ibacher