Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parent distro validation temporarily. #38

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

Ruhanga
Copy link
Contributor

@Ruhanga Ruhanga commented Jan 31, 2024

No description provided.

@rbuisson
Copy link
Contributor

rbuisson commented Feb 6, 2024

Thank you for the PR @Ruhanga . I am a bit hesitant to disable this entirely as I like that people inheriting Ozone Parent will automatically get an OpenMRS validation working. This is actually needed by KenyaHMIS.

Copy link
Contributor

@rbuisson rbuisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruhanga could you simply comment out this execution instead of deleting it, and drop a line of explanation along with it?

@ibacher
Copy link
Contributor

ibacher commented Feb 6, 2024

@rbuisson I think I've come around to the idea that this will just need to be part of the Maven archetype maintained for Ozone projects rather than the parent. There's no obvious escape hatch in Maven to only run this profile if it's being executed as part of a child job.

@Ruhanga
Copy link
Contributor Author

Ruhanga commented Feb 7, 2024

the idea that this will just need to be part of the Maven archetype maintained for Ozone projects rather than the parent.

I'm ok with it @ibacher. Feel free to close this, hoping that this could resolve soon so we can have published SNAPSHOTS.

@rbuisson rbuisson merged commit 93f74d1 into main Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants