Release/v0.1.22 #84
Merged
Release/v0.1.22 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add proper timeout error handling * Fix lint errors --------- Co-authored-by: Samuel Benattar <samuel.benattar@bytedance.com>
Co-authored-by: Sergei Makarov <33636772+siller174@users.noreply.github.com>
|
@samybenatt hello. I hope you are doing well. Could you please review this PR? |
samybenatt
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Hey @siller174
I reviewed all your implementation
I think one key difference between your implementation and mine is that, when one of the attempt is successful, I mark the whole test as successful, and I don't keep error history. I am only failing if the last attempt is still failing.
In your implementation, the test will start failing even after retrying.
The optional and broken error options are not really fulfilling the intended purpose because it is either setting all failures as broken/optional or all failures as failed. But the retry purpose is the following:
- The test will be retried up to
MaxAttemptstimes - The retries will only be executed if the test is having errors
- If the test is successful at any iteration between attempt 1 and
MaxAttempts, the loop will break and return the overall test result as successful (it will not process previous errors and it will never trigger t.Fail()) - The status of the overall test (success or fail) will be based on either the first attempt that is successful, or, if no attempt is successful, it will be based on the latest execution result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetrytestRequestRepeat*toRequestRetry*