Fix allocations in bytes_len_cmp #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillov6
approved these changes
Sep 6, 2024
goshansmails
approved these changes
Sep 6, 2024
HeadHunter483
force-pushed
the
671-fix-byte-len-cmp
branch
from
5058092
to
864b863
Compare
HeadHunter483
force-pushed
the
671-fix-byte-len-cmp
branch
from
864b863
to
727e0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces encoding object or array json node to counting bytes length recursively.
There can be a slight divergence in case when field names have escaping
\"since it will be considered as one symbol instead of two because of to process object fields insaneJSON AsField is called and it always escapes field names. But there is a huge advantage in memory consumption in this fix and such difference is negligible.Also there might be divergence when byte_len is computed after string field was unescaped in some action plugin and it should be considered when using this comparison condition.
Fixes #671