Skip to content
This repository has been archived by the owner on Nov 11, 2018. It is now read-only.

Use the clutter embed instead of the window as size reference #14

Merged
merged 1 commit into from
May 13, 2013

Conversation

tom95
Copy link
Contributor

@tom95 tom95 commented May 11, 2013

Using the clutter embed as size reference is more reliable, as not all window managers support hiding the menubar. The TerminalView will otherwise always be a couple of pixels too tall.

I also had to make sure keybinder-3.0 is requested, otherwise it would fail running as it mixes Gtk+-2 and 3 elements, not sure how you got it to run. (Valac-0.18 on Ubuntu 13.04 here)

@p-e-w
Copy link
Owner

p-e-w commented May 11, 2013

@TomB95: This looks good. I'll examine it in detail tomorrow (especially the keybinder reference issue, which has always been a problem) and merge it if everything is OK. Thank you very much for your effort :)

@p-e-w
Copy link
Owner

p-e-w commented May 11, 2013

@TomB95: I have found that unfortunately, changing "keybinder" to "keybinder-3.0" results in the package not being found on Fedora, while on Ubuntu Raring the reverse seems to be the case.

This is an ugly problem. Any idea how to fix it?

@tom95
Copy link
Contributor Author

tom95 commented May 11, 2013

@p-e-w I think you could benefit from a more abstract build system. I recommend cmake, there are a couple of helpful modules for it. If you generally like the idea of having cmake, I could make another pull request for it tomorrow. If you've never seen it before, here's an example from another project http://bazaar.launchpad.net/~gala-dev/gala/trunk/view/head:/CMakeLists.txt

@p-e-w
Copy link
Owner

p-e-w commented May 11, 2013

@TomB95: I have no experience using cmake, but it sounds like a wonderful idea. I would greatly appreciate if you could help me porting the build system to cmake!

On a side note, I am also a big fan of simplicity, and, above all, clarity (as you will see throughout the source code). I hope that moving to cmake will not require a makefile as bloated as that of many other projects.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants