Skip to content
This repository has been archived by the owner on Nov 11, 2018. It is now read-only.

Optimize ps termlet. Runs in ~1.3sec instead of ~2sec on an AMD E-350. #340

Merged
merged 6 commits into from
Aug 24, 2014
Merged

Optimize ps termlet. Runs in ~1.3sec instead of ~2sec on an AMD E-350. #340

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9b8530
Optimize ps termlet. Runs in ~1.3sec instead of ~2sec on an AMD E-350.
lwandrebeck Aug 20, 2014
21c077b
Optimize ps termlet. Runs in less than half a second instead of ~2sec…
lwandrebeck Aug 20, 2014
37d35e1
Merge branch 'termlets' of github.com:lwandrebeck/finalterm into term…
lwandrebeck Aug 21, 2014
318e4b0
Optimize ls termlet a bit. 11 sec for ~1000 files instead of 22 on an…
lwandrebeck Aug 21, 2014
74eb2eb
Remove a useless line in ps termlet.
lwandrebeck Aug 23, 2014
30cf259
Merge remote-tracking branch 'upstream/master' into termlets
lwandrebeck Aug 23, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions data/Termlets/ps
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
#!/bin/bash

lnnb=0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer variable names that can be immediately understood without deciphering abbreviations. How about first_line instead, with the initial value being true?

Also, that being said, can't the two if blocks actually be merged to create a much more concise and elegant termlet? Currently, we're checking whether we are in the header line in two different places using two different methods.

ps "$@" |

while IFS= read -r line; do
# Position of string "PID" in line
pid_index=$(awk -v a="$line" -v b='PID' 'BEGIN{print index(a,b)}')
if [ $lnnb == 0 ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this if block header followed the style of the one below. Also note http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-scripts, though it shouldn't matter much here.

then
# Position of string "PID" in line
pid_index=$(awk -v a="$line" -v b='PID' 'BEGIN{print index(a,b)}')
lnnb=1
fi

if [[ "$pid_index" -gt 0 ]]; then
# Header line
Expand All @@ -21,4 +26,5 @@ while IFS= read -r line; do
fi

echo -e "$modified_line"
pid_index=0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to do nothing.

done
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this extensively and noticed a speedup of at least a factor of 20. Great stuff!